Skip to content

fix(types): match native manager return values - #5078

Open
OskarEichler wants to merge 1 commit into
TheWidlarzGroup:support/6.x.xfrom
OskarEichler:codex/fix-native-manager-types
Open

fix(types): match native manager return values#5078
OskarEichler wants to merge 1 commit into
TheWidlarzGroup:support/6.x.xfrom
OskarEichler:codex/fix-native-manager-types

Conversation

@OskarEichler

Copy link
Copy Markdown

Fixes

Align the internal NativeModules.VideoManager interface with the actual bridges:

  • imperative commands return void, not promises
  • save is optional because Android and Windows do not export it
  • getCurrentPosition resolves a fractional JavaScript number rather than an Int32
  • React tags consistently use Int32

The incorrect promise declarations could encourage awaiting values that are actually undefined, and the integer position type discarded the native APIs' sub-second contract.

Regression coverage

The v6 branch has no test suite (yarn test reports no test available). Verified with:

  • YARN_NODE_LINKER=node-modules yarn prettier --check src/specs/NativeVideoManager.ts
  • YARN_NODE_LINKER=node-modules yarn build
  • YARN_NODE_LINKER=node-modules yarn lint
  • React Doctor (100/100, no findings)
  • git diff --check

Breaking changes

None for the public VideoRef API; this corrects the package-internal native-module declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant